[THRIFT-2163] incorrect Delphi code generated for typedef'ed constants

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: Delphi - Compiler
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 03/Sep/13 21:38
• Updated: 22/Apr/16 19:50
• Resolved: 08/Apr/16 05:36

Description

The following IDL

typedef map<string,Bonk> MapType
const ThriftTest.MapType MAPCONSTANT = {'hello':{}, 'goodnight':{}}

creates uncompileable code at FMAPCONSTANT, because TMapType is a reference to an interface type, not the implementing class type:

class constructor TConstants.Create;
begin
  FMAPCONSTANT := TMapType.Create;
end;

Expected code would be

class constructor TConstants.Create;
begin
  FMAPCONSTANT := TThriftDictionaryImpl<string, IBonk>.Create;
  FMAPCONSTANT.Add( 'hello', TBonkImpl.Create);
  FMAPCONSTANT.Add( 'goodnight', TBonkImpl.Create);
end;