[THRIFT-2150] Should windows/config.h define WIN32_LEAN_AND_MEAN?

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 0.9.1
• Component/s: C++ - Library
• Labels: c++ msvc thrift windows

Environment

MSVC

• Assignee: James E. King III
• Reporter: Chris Stylianou
• Created: 26/Aug/13 12:29
• Updated: 06/May/15 13:19
• Resolved: 06/May/15 13:19

Description

As "windows/config.h" includes Winsock2.h, is it not best practise to define before it:

WIN32_LEAN_AND_MEAN

This is in case someone includes Windows.h, which automatically includes the incompatible Winsock.h. It also reduces the size of the Win32 header files which helps compilation speeds