Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2150

Should windows/config.h define WIN32_LEAN_AND_MEAN?

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • 0.9.1
    • None
    • C++ - Library
    • MSVC

    Description

      As "windows/config.h" includes Winsock2.h, is it not best practise to define before it:

      WIN32_LEAN_AND_MEAN

      This is in case someone includes Windows.h, which automatically includes the incompatible Winsock.h. It also reduces the size of the Win32 header files which helps compilation speeds

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jking3 James E. King III
            chris5287 Chris Stylianou
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment