[THRIFT-2099] Stop TThreadPoolServer with alive connections.

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.9
• Fix Version/s: 0.9.3
• Component/s: C++ - Library

Environment

Ubuntu 12.04, Thrift 0.9, Nginx 1.4.1, Python 2.7.3, GCC 4.6.3

• Assignee: James E. King III
• Reporter: Aleksey Zanin
• Created: 24/Jul/13 04:39
• Updated: 21/Jul/15 02:21
• Resolved: 06/May/15 04:38

Description

Now if client of TThreadPoolServer kept alive connection (for example if requests to thrift-server are forwarded from nginx-server, which is set up so that the connections between him and thift-server are kept alive), method TThreadPoolServer::stop does not stopped server. It continues work until client (nginx-server) will not stopped.

void StopThread(shared_ptr<EchoService> const &echo_service_handler,
				shared_ptr<TThreadPoolServer> &server,
				shared_ptr<ThreadManager> &thread_manager)
{
	while (echo_service_handler->GetRequestsCount() < 3)
	{
		sleep(1);
	}
	std::cout << "Stop service." << std::endl;
	server->stop();
}

I think that ability to stop thrift-server with alive connections will be useful.

Issue Links

• duplicates: THRIFT-2441 Cannot shutdown TThreadedServer when clients are still connected