Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2026

Fix TCompactProtocol 64 bit builds

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9
    • 0.9.2, 0.11.0
    • C++ - Library
    • None

    • Mac 64, Win 64, Linux 64

    • Patch Available

    Description

      TCompactProtocol has several places where it truncates a size_t to a 32-bit value.

      TCompactProtocol also does bitwise operations on signed values, which has undefined behavior.

      Attachments

        1. compact_int_stuff.patch
          2 kB
          Ben Craig

        Issue Links

          relates to

          Task - A task that needs to be done. IMPALA-5031 UBSAN clean and method for testing UBSAN cleanliness

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • In Progress
          links to

          Web Link GitHub Pull Request #1214

          Activity

            People

              ben.craig Ben Craig
              ben.craig Ben Craig
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: