[THRIFT-2004] Thrift::Union violates :== method contract and crashes

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.3
• Component/s: Ruby - Library

Environment

MacOS X, ruby 1.9 and 2.0

• Assignee: Unassigned
• Reporter: Jeff Reinecke
• Created: 07/Jun/13 19:15
• Updated: 21/Jul/15 02:21
• Resolved: 01/Jun/15 20:02

Description

Thrift::Union violates the contract for the :== method, by assuming that the passed argument is either nil or a Thrift::Union (by calling methods that only exist on Thrift::Union). An extra clause should be put in to test if it is not a Union and fail.

Idiomatically, this should be done via duck typing making the method be:
def ==(other)
nil && other.repond_to?(:get_set_field) && other.respond_to?(:get_value) && @setfield == other.get_set_field && @value == other.get_value
end

Issue Links

• duplicates: THRIFT-3176 Union incorrectly implements ==
• is related to: THRIFT-3176 Union incorrectly implements ==