Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1915 Multiplexing Services
  3. THRIFT-1901

C#: Support for Multiplexing Services on any Transport, Protocol and Server

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.1
    • Component/s: C# - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      See THRIFT-563 for Details.

        Issue Links

          Activity

          Hide
          jensg Jens Geyer added a comment -

          First try, not yet tested with Mono.

          Show
          jensg Jens Geyer added a comment - First try, not yet tested with Mono.
          Hide
          jensg Jens Geyer added a comment -

          Added alternative "sbyte" Version of the patch, depending on whether THRIFT-1930 has been fixed or not.

          Show
          jensg Jens Geyer added a comment - Added alternative "sbyte" Version of the patch, depending on whether THRIFT-1930 has been fixed or not.
          Hide
          jensg Jens Geyer added a comment -

          Patches v2: now works with Mono on Ubuntu

          Show
          jensg Jens Geyer added a comment - Patches v2: now works with Mono on Ubuntu
          Hide
          carlyeks Carl Yeksigian added a comment -

          Overall, looks good.

          A couple of comments:

          1. In TMultiplexedProcessor, there is a todo comment in Process. I think that we should be sending the exception back to the client, instead of throwing the exception in the server. This is what happens in the case where a function isn't found, which seems like the type of operation that is happening here.
          2. The tests need to be updated for sbyte.
          Show
          carlyeks Carl Yeksigian added a comment - Overall, looks good. A couple of comments: In TMultiplexedProcessor, there is a todo comment in Process. I think that we should be sending the exception back to the client, instead of throwing the exception in the server. This is what happens in the case where a function isn't found, which seems like the type of operation that is happening here. The tests need to be updated for sbyte.
          Hide
          jensg Jens Geyer added a comment -

          I think that we should be sending the exception back to the client, instead of throwing the exception in the server.

          Good point, I modified the patch accordingly.

          The tests need to be updated for sbyte.

          Yep.

          Show
          jensg Jens Geyer added a comment - I think that we should be sending the exception back to the client, instead of throwing the exception in the server. Good point, I modified the patch accordingly. The tests need to be updated for sbyte. Yep.
          Hide
          carlyeks Carl Yeksigian added a comment -

          +1

          Show
          carlyeks Carl Yeksigian added a comment - +1
          Hide
          jensg Jens Geyer added a comment - - edited

          Thanks, committed including THRIFT-1961.

          Show
          jensg Jens Geyer added a comment - - edited Thanks, committed including THRIFT-1961 .
          Hide
          hudson Hudson added a comment -

          Integrated in Thrift #646 (See https://builds.apache.org/job/Thrift/646/)
          THRIFT-1901 C#: Support for Multiplexing Services on any Transport, Protocol and Server (Revision 7203424e96146e03e770bae7809d9e03cbecdcfc)

          Result = SUCCESS
          jensg :
          Files :

          • lib/csharp/src/Protocol/TMultiplexedProtocol.cs
          • lib/csharp/test/Multiplex/Client/Multiplex.Test.Client.cs
          • lib/csharp/src/Thrift.csproj
          • lib/csharp/test/Multiplex/Multiplex.Test.Common.cs
          • lib/csharp/test/Multiplex/maketest.sh
          • lib/csharp/test/Multiplex/Client/Properties/AssemblyInfo.cs
          • lib/csharp/src/Thrift.WP7.csproj
          • lib/csharp/Makefile.am
          • lib/csharp/test/Multiplex/Server/Multiplex.Test.Server.cs
          • lib/csharp/src/Protocol/TMultiplexedProcessor.cs
          • lib/csharp/src/Protocol/TProtocolDecorator.cs
          • lib/csharp/test/Multiplex/Server/Properties/AssemblyInfo.cs
          • lib/csharp/test/Multiplex/Client/MultiplexClient.csproj
          • lib/csharp/test/Multiplex/Server/MultiplexServer.csproj
          Show
          hudson Hudson added a comment - Integrated in Thrift #646 (See https://builds.apache.org/job/Thrift/646/ ) THRIFT-1901 C#: Support for Multiplexing Services on any Transport, Protocol and Server (Revision 7203424e96146e03e770bae7809d9e03cbecdcfc) Result = SUCCESS jensg : Files : lib/csharp/src/Protocol/TMultiplexedProtocol.cs lib/csharp/test/Multiplex/Client/Multiplex.Test.Client.cs lib/csharp/src/Thrift.csproj lib/csharp/test/Multiplex/Multiplex.Test.Common.cs lib/csharp/test/Multiplex/maketest.sh lib/csharp/test/Multiplex/Client/Properties/AssemblyInfo.cs lib/csharp/src/Thrift.WP7.csproj lib/csharp/Makefile.am lib/csharp/test/Multiplex/Server/Multiplex.Test.Server.cs lib/csharp/src/Protocol/TMultiplexedProcessor.cs lib/csharp/src/Protocol/TProtocolDecorator.cs lib/csharp/test/Multiplex/Server/Properties/AssemblyInfo.cs lib/csharp/test/Multiplex/Client/MultiplexClient.csproj lib/csharp/test/Multiplex/Server/MultiplexServer.csproj

            People

            • Assignee:
              jensg Jens Geyer
              Reporter:
              jensg Jens Geyer
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development