[THRIFT-1823] Missing parenthesis breaks "IS_..." macro in generated code

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.1
• Component/s: C glib - Compiler

Environment

CentOS 6.3 on x86 (32-bit)

• Patch Info: Patch Available
• Assignee: Simon South
• Reporter: Simon South
• Created: 06/Jan/13 23:59
• Updated: 08/Jun/13 03:15
• Resolved: 08/Jun/13 03:15

Description

A missing parenthesis in the generated header file for a service interface breaks the "IS_..." macro, making client code that uses it fail to compile with messages like

hello_world_processor.c:41:59: error: macro "G_TYPE_CHECK_INSTANCE_TYPE" requires 2 arguments, but only 1 given
hello_world_processor.c:101:1: error: unterminated argument list invoking macro "G_LIKELY"
In file included from /usr/include/glib-2.0/glib.h:79,
from /usr/include/glib-2.0/gobject/gtype.h:26,
from /usr/include/glib-2.0/gobject/gboxed.h:26,
from /usr/include/glib-2.0/glib-object.h:25,
from hello_world_processor.h:4,
from hello_world_processor.c:1:

I'll attach a patch with the fix.