Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1813

Add @Generated annotation to generated classes

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.9.2
    • Java - Compiler
    • None

    Description

      Why?

      1. A lot of static analysis tools understand the javax.annotation.Generated annotation and treat those classes differently.
      2. Setting the date field with the date & comments field with the version of the thrift compiler might prove to be valuable for tracing the origins of the generated file.

      The overheads should be minimal as the retention policy of the annotation is purely at a source level

      Attachments

        1. THRIFT-1813.patch
          3 kB
          Andrew Gaul
        2. thrift-1813-generated-annotation.patch
          3 kB
          Arvind Jayaprakash

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            roger Roger Meier
            anomalizer Arvind Jayaprakash
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment