Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1748

Guard and RWGuard macros defined in global namespace

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.9
    • 0.9.1
    • C++ - Library
    • Visual Studio 2010

    • Patch Available

    Description

      thrift/concurrency/Mutex.h defines global macros Guard and RWGuard. Although the purpose is well commented and appreciated - i.e. trying to prevent coders from creating temporary variables and falsely assuming they have a lock - this code does interfere with other packages that define their own Guard classes. Even when the user/library define Guard in their own namespace, there's a clash.

      Please remove the macros.

      Attachments

        Activity

          People

            roger Roger Meier
            budric Bud Bundy
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: