[THRIFT-1748] Guard and RWGuard macros defined in global namespace

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.1
• Component/s: C++ - Library
• Labels: newbie patch

Environment

Visual Studio 2010

• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Bud Bundy
• Created: 07/Nov/12 16:01
• Updated: 08/Jun/13 03:15
• Resolved: 08/Jun/13 03:15

Description

thrift/concurrency/Mutex.h defines global macros Guard and RWGuard. Although the purpose is well commented and appreciated - i.e. trying to prevent coders from creating temporary variables and falsely assuming they have a lock - this code does interfere with other packages that define their own Guard classes. Even when the user/library define Guard in their own namespace, there's a clash.

Please remove the macros.