[THRIFT-1740] Make C++ library build on OS X and iOS

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.1
• Component/s: C++ - Library
• Labels: c++ ios mac

Environment

Patch fixes OS X xcode 3.2 with gcc 4.2 toolchain. Also fixes iOS xcode 4.4 with clang 4.0 toolchain.

• Patch Info: Patch Available
• Assignee: Ben Craig
• Reporter: Ben Craig
• Created: 24/Oct/12 22:05
• Updated: 20/Feb/21 15:28
• Resolved: 08/Jun/13 03:15

Description

Various small issues keep the existing Thrift c++ libraries from building on OS X and iOS. For example, in Clang, there is no <tr1/functional>, only a regular <functional>. Instead of adding a new configure token and a million #ifdefs, the patch has added a wrapper header that throws the relevant <functional> symbols into the apache::thrift:stdcxx namespace.

There are also several fixes for unused variable warnings in release mode. I have added a helper macro to better document these cases (as opposed to just adding the mysterious "ret=ret;" everywhere).

Issue Links

• is cloned by: THRIFT-5241 Make C++ library build on OS X and iOS