Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1740

Make C++ library build on OS X and iOS

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9, 1.0
    • Fix Version/s: 0.9.1
    • Component/s: C++ - Library
    • Labels:
    • Environment:

      Patch fixes OS X xcode 3.2 with gcc 4.2 toolchain. Also fixes iOS xcode 4.4 with clang 4.0 toolchain.

    • Patch Info:
      Patch Available

      Description

      Various small issues keep the existing Thrift c++ libraries from building on OS X and iOS. For example, in Clang, there is no <tr1/functional>, only a regular <functional>. Instead of adding a new configure token and a million #ifdefs, the patch has added a wrapper header that throws the relevant <functional> symbols into the apache::thrift:stdcxx namespace.

      There are also several fixes for unused variable warnings in release mode. I have added a helper macro to better document these cases (as opposed to just adding the mysterious "ret=ret;" everywhere).

        Attachments

        1. mac_and_ios.patch
          30 kB
          Ben Craig

          Activity

            People

            • Assignee:
              ben.craig Ben Craig
              Reporter:
              ben.craig Ben Craig
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: