[THRIFT-1664] Reference to non-existing variable in build script

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.8
• Fix Version/s: 0.9
• Component/s: Build Process
• Assignee: Christopher Rogers
• Reporter: Christopher Rogers
• Created: 29/Jul/12 08:32
• Updated: 13/Aug/12 04:38
• Resolved: 13/Aug/12 04:05

Description

In the file "aclocal/ax_signed_right_shift.m4" on line 107, the last "l" in the variable $success_logical is missing. I know nothing of the language this file uses, but since this actually builds I assume this will always evaluate to no.

          if test "$success_arithmetic" = "yes" && test "$success_logica" = "yes" ; then
            AC_MSG_ERROR("Right shift appears to be both arithmetic and logical!")
          elif test "$success_arithmetic" = "yes" ; then
            ax_signed_right_shift=arithmetic
            AC_DEFINE([SIGNED_RIGHT_SHIFT_IS], 1,
                      [Indicates the effect of the right shift operator
                       on negative signed integers])
          elif test "$success_logical" = "yes" ; then
            ax_signed_right_shift=logical
            AC_DEFINE([SIGNED_RIGHT_SHIFT_IS], 2,
                      [Indicates the effect of the right shift operator
                       on negative signed integers])
          else
            ax_signed_right_shift=unknown
            AC_DEFINE([SIGNED_RIGHT_SHIFT_IS], 3,
                      [Indicates the effect of the right shift operator
                       on negative signed integers])
          fi