Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1664

Reference to non-existing variable in build script

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.8
    • 0.9
    • Build Process
    • None

    Description

      In the file "aclocal/ax_signed_right_shift.m4" on line 107, the last "l" in the variable $success_logical is missing. I know nothing of the language this file uses, but since this actually builds I assume this will always evaluate to no.

                if test "$success_arithmetic" = "yes" && test "$success_logica" = "yes" ; then
                  AC_MSG_ERROR("Right shift appears to be both arithmetic and logical!")
                elif test "$success_arithmetic" = "yes" ; then
                  ax_signed_right_shift=arithmetic
                  AC_DEFINE([SIGNED_RIGHT_SHIFT_IS], 1,
                            [Indicates the effect of the right shift operator
                             on negative signed integers])
                elif test "$success_logical" = "yes" ; then
                  ax_signed_right_shift=logical
                  AC_DEFINE([SIGNED_RIGHT_SHIFT_IS], 2,
                            [Indicates the effect of the right shift operator
                             on negative signed integers])
                else
                  ax_signed_right_shift=unknown
                  AC_DEFINE([SIGNED_RIGHT_SHIFT_IS], 3,
                            [Indicates the effect of the right shift operator
                             on negative signed integers])
                fi
      

      Attachments

        Activity

          People

            christorogers Christopher Rogers
            christorogers Christopher Rogers
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: