[THRIFT-1573] Error on TNonblockingServer constructor

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8
• Component/s: C++ - Library
• Labels: TNonblockingServer
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Denis
• Created: 14/Apr/12 10:57
• Updated: 18/Jun/12 20:44
• Resolved: 18/Jun/12 20:03

Description

If the TNonblockingServer is to construct:
TNonblockingServer server(processorFactory, protocolFactory, port, threadManager);

the compiler generates an error:
error C2664: apache::thrift::server::TServer::TServer(const apache::thrift::server::TServer &): cannot convert parameter 1 from "const boost::shared_ptr<T>" to "const apache::thrift::server::TServer &" e:\develop\cpp\lib\thrift\src\server\tnonblockingserver.h 264

patch:

Index: TServer.h
===================================================================
--- TServer.h	(revision 1337971)
+++ TServer.h	(working copy)
@@ -142,7 +142,7 @@
 
 protected:
   template<typename ProcessorFactory>
-  TServer(const boost::shared_ptr<TProcessorFactory>& processorFactory,
+  TServer(const boost::shared_ptr<ProcessorFactory>& processorFactory,
           THRIFT_OVERLOAD_IF(ProcessorFactory, TProcessorFactory)):
     processorFactory_(processorFactory) {
     setInputTransportFactory(boost::shared_ptr<TTransportFactory>(
@@ -166,7 +166,7 @@
   }
 
   template<typename ProcessorFactory>
-  TServer(const boost::shared_ptr<TProcessorFactory>& processorFactory,
+  TServer(const boost::shared_ptr<ProcessorFactory>& processorFactory,
           const boost::shared_ptr<TServerTransport>& serverTransport,
           THRIFT_OVERLOAD_IF(ProcessorFactory, TProcessorFactory)):
     processorFactory_(processorFactory),

Issue Links

• Is contained by: THRIFT-1631 Fix C++ server constructor typos