[THRIFT-1552] Thrift (cpp) include files shouldn't require adding "thrift" to the compilers include path.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8
• Component/s: C++ - Compiler, C++ - Library
• Labels: cpp include path

Environment

All

• Assignee: Ricky Cormier
• Reporter: Ricky Cormier
• Created: 05/Apr/12 07:41
• Updated: 30/Jul/14 01:48
• Resolved: 13/Apr/12 09:14

Description

When including thrift header files it is necessary to add thrift to the compilers include path. Headers are then included something like this...

#include <thrift.h>
#include <server/TNonblockingServer.h>
#include <protocol/TBinaryProtocol.h>

... and so on.

It is generally preferable to have include paths prefixed with the name of the library to which they belong. This not only prevents the possibility of include ambiguity it also acts as documentations and aids readability.

This changes is to allow the header files to be included with "thrift" as the leading path leaf...

#include <thrift/thrift.h>
#include <thrift/server/TNonblockingServer.h>
#include <thrift/protocol/TBinaryProtocol.h>

We have already made this change to our version of thrift-0.5.0 and I am currently working on patching this change to trunk.

Issue Links

• incorporates: THRIFT-2014 Change C++ lib includes to use <namespace/> style throughout
• relates to: THRIFT-1968 Thrift's include path is wrong in pkg-config files