[THRIFT-1551] 2 thrift file define only struct (no service), one include another, the gen nodejs file didn't have "requires" at the top

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Fix Version/s: 0.9.1
• Component/s: Node.js - Compiler

Environment

ubuntu 11.10

• Assignee: Unassigned
• Reporter: Mars Hsu
• Created: 05/Apr/12 07:27
• Updated: 20/Feb/21 15:27
• Resolved: 26/Aug/13 16:40

Description

I talk Wade Simmons with this issue today

Mars
hi wade,do you got my email?
下午2:57

Wade
yes, what version of thrift are you using?

Mars
0.8.0
the lastest
it seems, the bug didn't fix

Wade
hmm, that is strange, it should have that patch merged
perhaps it is a different issue
下午2:59

Mars
two struct defined thrife, one include another, the gen nodejs file, didn't have reqiured ttypes at the top of file
i think they are same issue
下午3:01

Wade
the code from that ticket has been merged in, so there must be a bug that you are running into that wasn't tested as part of that patch
not sure what the issue is that you are hitting though
you might need to open a new ticket with example files
下午3:12

Wade
oh, are you defining a thrift service?
or just a thrift struct?
下午3:14

Wade
the current code until works with a service that extends another service

Mars
yes, just 2 thrift file, with only structs, the service define in *_service.thrift, I checkout the include of file with service defined is work fine

Wade
yeah, there is a bug with structs that extend other structs it looks like
you should open a new bug

Issue Links

• duplicates: THRIFT-1402 Generated Y_types.js does not require() X_types.js when an include in the IDL file was used