[THRIFT-1549] Python TSSLSocket: Shutdown cleanly

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.8
• Fix Version/s: 0.13.0
• Component/s: Python - Library
• Patch Info: Patch Available
• Assignee: James E. King III
• Reporter: Yuri Khan
• Created: 29/Mar/12 12:15
• Updated: 16/Oct/19 22:26
• Resolved: 27/Jan/19 13:23

Description

When attempting to use Thrift over SSL, from a Python client to a C++ server, I noticed in the server logs:

Thrift: Thu Mar 29 18:45:02 2012 SSL_shutdown: error code: 0

This seems to be caused by unclean shutdown by the Python client library where TSocket just closes its socket, and is fixed by the following patch (against Thrift 0.8):

diff --git a/TSSLSocket.py~ b/TSSLSocket.py
index 15095d3..3e3fd2d 100644
--- a/TSSLSocket.py~
+++ b/TSSLSocket.py
@@ -88,6 +88,10 @@ class TSSLSocket(TSocket.TSocket):
     if self.validate:
       self._validate_cert()
 
+  def close(self):
+    self.handle = self.handle.unwrap()
+    TSocket.TSocket.close(self)
+
   def _validate_cert(self):
     """internal method to validate the peer's SSL certificate, and to check the
     commonName of the certificate to ensure it matches the hostname we

If needed, ping me, I will do a rebase to HEAD.

Issue Links

• links to: GitHub Pull Request #1717