Thrift
  1. Thrift
  2. THRIFT-1549

Python TSSLSocket: Shutdown cleanly

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.8
    • Fix Version/s: None
    • Component/s: Python - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      When attempting to use Thrift over SSL, from a Python client to a C++ server, I noticed in the server logs:

      Thrift: Thu Mar 29 18:45:02 2012 SSL_shutdown: error code: 0
      

      This seems to be caused by unclean shutdown by the Python client library where TSocket just closes its socket, and is fixed by the following patch (against Thrift 0.8):

      diff --git a/TSSLSocket.py~ b/TSSLSocket.py
      index 15095d3..3e3fd2d 100644
      --- a/TSSLSocket.py~
      +++ b/TSSLSocket.py
      @@ -88,6 +88,10 @@ class TSSLSocket(TSocket.TSocket):
           if self.validate:
             self._validate_cert()
       
      +  def close(self):
      +    self.handle = self.handle.unwrap()
      +    TSocket.TSocket.close(self)
      +
         def _validate_cert(self):
           """internal method to validate the peer's SSL certificate, and to check the
           commonName of the certificate to ensure it matches the hostname we
      

      If needed, ping me, I will do a rebase to HEAD.

        Activity

        Hide
        Yuri Khan added a comment -

        This breaks the Python—Python scenario: now when doing the unwrap, the client raises an exception saying error: [Errno 0] Error. Would be nice to shutdown cleanly at both sides but I don’t know how to do it at the moment.

        Show
        Yuri Khan added a comment - This breaks the Python—Python scenario: now when doing the unwrap , the client raises an exception saying error: [Errno 0] Error . Would be nice to shutdown cleanly at both sides but I don’t know how to do it at the moment.
        Yuri Khan created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Yuri Khan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development