Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1548

PHP TCompactProtocol always reads bools as false

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.8
    • 0.10.0
    • PHP - Library
    • None
    • Patch Available

    Description

      In TCompactProtocol::readFieldBegin, $field_type should be compared to COMPACT_TRUE or COMPACT_FALSE before being converted to a TType. Otherwise, $field_type will be converted to TType::BOOL (0x02) and will always match COMPACT_FALSE (0x02).

      Attachments

        1. TCompactProtocol.php.patch
          0.7 kB
          Gregory Hart

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-3348 PHP TCompactProtocol bool&int64 readvalue bug

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-5538 TCompactProtocol always decode bool fields as false

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              hakon Håkon Hitland
              freastro Gregory Hart
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: