Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1548

PHP TCompactProtocol always reads bools as false

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.8
    • 0.10.0
    • PHP - Library
    • None
    • Patch Available

    Description

      In TCompactProtocol::readFieldBegin, $field_type should be compared to COMPACT_TRUE or COMPACT_FALSE before being converted to a TType. Otherwise, $field_type will be converted to TType::BOOL (0x02) and will always match COMPACT_FALSE (0x02).

      Attachments

        1. TCompactProtocol.php.patch
          0.7 kB
          Gregory Hart

        Issue Links

          Activity

            srupf Simon Rupf added a comment -

            Dear Customer,

            I have left boxalino AG as of the end of October 2015 and will be tackling new challanges. Please direct your general technical questions to support@boxalino.com or directly contact Mister Sylvain Paillard (sylvain.paillard@boxalino.com / +41 43 210 33 65).

            It was always a great pleasure working at boxalino and to support our customers to implement new and exciting solutions.

            I wish you and your business all the best.

            Kind regards,
            Simon Rupf

            Sehr geehrte Kundin,
            Sehr geehrter Kunde

            Ich bin aus der boxalino AG per Ende Oktober 2015 ausgeschieden und habe eine neue Herausforderung angenommen. Gerne k?nnen Sie sich f?r allgemeine technische Anfragen an support@boxalino.com oder auch direkt an Herrn Sylvain Paillard (sylvain.paillard@boxalino.com / +41 43 210 33 65) wenden.

            Es hat mir stets grosse Freude bereitet bei boxalino zu arbeiten und unsere Kunden dabei zu unterst?tzen spannende und neuartige L?sungen umzusetzen.

            Ich w?nsche Ihnen weiterhin gute Gesch?fte und verbleibe,

            Mit besten Gr?ssen
            Simon Rupf

            srupf Simon Rupf added a comment - Dear Customer, I have left boxalino AG as of the end of October 2015 and will be tackling new challanges. Please direct your general technical questions to support@boxalino.com or directly contact Mister Sylvain Paillard (sylvain.paillard@boxalino.com / +41 43 210 33 65). It was always a great pleasure working at boxalino and to support our customers to implement new and exciting solutions. I wish you and your business all the best. Kind regards, Simon Rupf — Sehr geehrte Kundin, Sehr geehrter Kunde Ich bin aus der boxalino AG per Ende Oktober 2015 ausgeschieden und habe eine neue Herausforderung angenommen. Gerne k?nnen Sie sich f?r allgemeine technische Anfragen an support@boxalino.com oder auch direkt an Herrn Sylvain Paillard (sylvain.paillard@boxalino.com / +41 43 210 33 65) wenden. Es hat mir stets grosse Freude bereitet bei boxalino zu arbeiten und unsere Kunden dabei zu unterst?tzen spannende und neuartige L?sungen umzusetzen. Ich w?nsche Ihnen weiterhin gute Gesch?fte und verbleibe, Mit besten Gr?ssen Simon Rupf
            barrylb Barry Brannan added a comment -

            this was fixed in THRIFT-3348

            barrylb Barry Brannan added a comment - this was fixed in THRIFT-3348

            is there a way to write test for that issue?

            hcorg Konrad Grochowski added a comment - is there a way to write test for that issue?
            srupf Simon Rupf added a comment -

            We have just encountered this issue in our company with one of our thrift APIs. The patch worked with the php libs from 0.9.2. Thank you very much!

            Is there any way I could help to bring this patch into a future release?

            srupf Simon Rupf added a comment - We have just encountered this issue in our company with one of our thrift APIs. The patch worked with the php libs from 0.9.2. Thank you very much! Is there any way I could help to bring this patch into a future release?
            freastro Gregory Hart added a comment -

            The patch is attached.

            freastro Gregory Hart added a comment - The patch is attached.

            People

              hakon Håkon Hitland
              freastro Gregory Hart
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: