[THRIFT-1522] TServerSocket potential memory leak with addrinfo *res0

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.8
• Fix Version/s: 0.10.0
• Component/s: C++ - Library
• Labels: TServerSocket leak memory thrift

Environment

Unix, Windows

• Assignee: Peace C
• Reporter: Peace C
• Created: 23/Feb/12 19:36
• Updated: 18/Mar/16 18:02
• Resolved: 18/Mar/16 18:02

Description

I noticed a potential memory leak in TServerSocket.cpp. The res0 pointer receives an allocation from getaddrinfo() but is only freed part of the time in a conditional branch. It should be outside of the if-else to ensure it's deallocated every time.

I'm holding off on creating a patch in case I'm not understanding some hidden functionality in the socket library. Here is the code snippet:

struct addrinfo *res0;
...
getaddrinfo(NULL, port, &hints, &res0);
...
if (! path_.empty())

{ ... }

else

{ ... freeaddrinfo(res0); //Line 331 of TServerSocket.cpp }

Issue Links

• duplicates: THRIFT-1201 getaddrinfo resource leak