Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 0.9
    • Component/s: C++ - Library
    • Environment:

      Windows XP, Visual Studio

    • Patch Info:
      Patch Available

      Description

      This is a follow-up patch to THRIFT-1490. The previous code would never follow the Windows XP path (WINVER 0x0501). At least that appears to be the case since poll_win32() was incomplete and not functional. Windows' version of select() does not set the revents field so FD_ISSET is used to determine how to manually set it. I've tested this on a sample project and it's working as expected. config.h is now targeting XP for wider compatibility. If this isn't desired or you don't trust the new code, comment out the two #define lines toward the top and it will revert to targeting Vista/Win7.

        Activity

        Jake Farrell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Roger Meier made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Peace C [ peace ]
        Resolution Fixed [ 1 ]
        Peace C made changes -
        Attachment Thrift_XP_skt_UNIXEOL.patch [ 12513491 ]
        Peace C made changes -
        Attachment Thrift_XP_skt.patch [ 12512672 ]
        Peace C made changes -
        Attachment Thrift_XP_skt.patch [ 12512672 ]
        Peace C made changes -
        Attachment Thrift_XP_skt.patch [ 12512470 ]
        Peace C made changes -
        Attachment Thrift_XP_skt.patch [ 12512470 ]
        Peace C made changes -
        Comment [ path w/ Unix EOLs ]
        Peace C made changes -
        Attachment Thrift_XP_skt.patch [ 12512469 ]
        Peace C made changes -
        Field Original Value New Value
        Attachment Thrift_XP_skt.patch [ 12512469 ]
        Peace C created issue -

          People

          • Assignee:
            Peace C
            Reporter:
            Peace C
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development