[THRIFT-1479] Compiled PHP process functions missing writeMessageEnd()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8
• Fix Version/s: 0.9
• Component/s: PHP - Compiler
• Patch Info: Patch Available
• Assignee: Andrew Grumet
• Reporter: Andrew Grumet
• Created: 31/Dec/11 17:16
• Updated: 03/Jan/12 17:56
• Resolved: 03/Jan/12 17:35

Description

While testing a PHP implementation of TJSONProtocol, we noticed that the process_* functions created by

thrift -r --gen php:server

were missing a call to

$output->writeMessageEnd();

This probably went unnoticed in testing to this point because TBinaryProtocol.php does not issue a message end marker. But with JSON, the message needs to be closed with a closing square bracket.

The attached patch adds the message end call.

Generated code has been tested with ThriftTest.thrift and TBinaryProtocol, as well as with our new JSON implementation.