[THRIFT-1458] use the C++ standard (c++0x or later c++11) to improve code quality and cross platform capability

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: C++ - Compiler, C++ - Library

Environment

gcc, llvm, visualstudio

• Assignee: Roger Meier
• Reporter: Roger Meier
• Created: 09/Dec/11 21:35
• Updated: 21/Jun/13 18:42
• Resolved: 19/Jun/13 23:12

Description

The goal is improvment of code quality and cross platform capability.

I did several test on Debian Squeeze with default packages of gcc(4.4.5) and clang(2.7)

Thrift Compiler only
sh bootstrap.sh ; ./configure --without-cpp --without-csharp --without-java --without-erlang --without-python --without-perl --without-php --without-php_extension --without-ruby --without-haskell

CXX=g++
=> ok
CXX=g++ CXXFLAGS='-std=c++0x'
=> ok

CXX=clang++
=> ok
CXX=clang++ CXXFLAGS='-std=c++0x'
=> fail

Thrift C++ Library
sh bootstrap.sh ; ./configure --without-csharp --without-java --without-erlang --without-python --without-perl --without-php --without-php_extension --without-ruby --without-haskell

CXX=clang++
=> fail
CXX=clang++ CXXFLAGS='-std=c++0x'
=> fail

CXX=g++
=> ok
CXX=g++ CXXFLAGS='-std=c++0x'
=> ok (since THRIFT-1459)

further info on supported features

• http://gcc.gnu.org/projects/cxx0x.html
• http://clang.llvm.org/cxx_status.html
• http://blogs.msdn.com/b/vcblog/archive/2010/04/06/c-0x-core-language-features-in-vc10-the-table.aspx

Issue Links

• is duplicated by: THRIFT-2022 CoB and dense code generation still uses TR1 bind, even though that doesn't work with clang
• is related to: THRIFT-1462 add more strict compiler flags

Sub-Tasks

• declare shared_ptr as boost::shared_ptr: Closed
• add more strict compiler flags: Closed