Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1444

FunctionRunner - add syntactic sugar to create shared_ptrs

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.9
    • C++ - Library
    • None

    Description

      From e1a2d69c5e178675e40aee3f01dadfebf11ca07b Mon Sep 17 00:00:00 2001
      From: Mark Rabkin <mrabkin@fb.com>
      Date: Fri, 11 Jun 2010 21:44:13 +0000
      Subject: [PATCH 03/56] FunctionRunner - add syntactic sugar to create shared_ptrs

      Summary:

      For FunctionRunner, you used to have to do a really awkward and
      verbose looking thing like:

      (...)->addTask(boost::shared_ptr<FunctionRunner>(new FunctionRunner(
      ... args ... )));

      Now you can do:

      (...)->addTask(FunctionRunner::create( ... args ... ));

      Reviewers: simpkins,dreiss

      CC: thrift-team@lists.facebook.com

      Test Plan: ran concurrency test

      Attachments

        Activity

          People

            davejwatson@fb Dave Watson
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: