[THRIFT-1432] Javascript struct constants declared in the same file as their struct definition will cause an error

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.8
• Component/s: JavaScript - Compiler
• Patch Info: Patch Available
• Assignee: Mike Riley
• Reporter: Mike Riley
• Created: 19/Nov/11 12:04
• Updated: 21/Nov/11 14:17
• Resolved: 21/Nov/11 13:54

Description

Constants are written out to the generated javascript file before structs are, so if you declare a constant that is of a type declared in the same file, you'll get an error telling you '<member name> is not a property of undefined' or something similar.

I fixed this by swapping the order in which structs and constants are written out in t_generator, and it doesn't seem to have broken anything in java, javascript, cocoa, php or c++. However, it could probably use a little testing in other languages.