Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1430

Fixes for property warnings generated in struct headers

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Won't Do
    • Affects Version/s: 0.7
    • Fix Version/s: 0.13.0
    • Component/s: Cocoa - Compiler
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Every struct generates warnings in the header because the properties are declared twice, once implicitly through the property declaration and once explicitly by the actual function declarations. This was done to increase compatibility with older versions of objective c that didn't have the ability to use the property syntax as it is declared now. This is harmless but you get two warnings per struct member, and in my case that worked out to a few hundred warnings.

      The fix here is a simple refactor for isSet method declaration, and placing the declaration of the alternate getter/setter implementations into an #else statement beneath the currently existing #if statement, as opposed to just declaring them.

        Attachments

        1. thrift-1430.patch
          2 kB
          Mike Riley

          Issue Links

            Activity

              People

              • Assignee:
                jking3 James E. King III
                Reporter:
                yelirekim Mike Riley
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: