[THRIFT-1427] PHP library uses non-multibyte safe functions with mbstring function overloading

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.9
• Component/s: PHP - Library
• Labels: patch php

Environment

PHP 5.2.6

• Patch Info: Patch Available
• Assignee: Bryan Alves
• Reporter: Bryan Alves
• Created: 15/Nov/11 20:56
• Updated: 29/Nov/11 17:41
• Resolved: 29/Nov/11 16:47

Description

The PHP library uses strlen() and substr() liberally. These functions can be overriden by mbstring with the config "mbstring.func_overload" (http://us.php.net/manual/en/mbstring.overload.php).

When this overloading happens, substr and strlen (among other non-important functions) are no longer binary-safe, and need to be replaced with their mb_* binary safe equivalents.

Attached is a patch that identifies environments where mbstring.func_overloading is set, and automatically switches over use of the non-binarysafe functions to their safe equivalents.