[THRIFT-1424] Ruby specs fail when run with rake

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.8
• Fix Version/s: 0.8
• Component/s: Ruby - Library
• Patch Info: Patch Available
• Assignee: Peter Sanford
• Reporter: Peter Sanford
• Created: 09/Nov/11 21:32
• Updated: 10/Nov/11 01:37
• Resolved: 10/Nov/11 00:54

Description

If I run rake in the rb directory the specs fail to load the spec_helper:

spec/serializer_spec.rb:23:in `require': no such file to load -- spec/spec_helper (LoadError)
        from spec/serializer_spec.rb:23:in `<top (required)>'
        from /home/psanford/.rvm/gems/ruby-1.9.2-p180@thrift/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:15:in `load'
        from /home/psanford/.rvm/gems/ruby-1.9.2-p180@thrift/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:15:in `block in load_files'
        from /home/psanford/.rvm/gems/ruby-1.9.2-p180@thrift/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:14:in `each'
        from /home/psanford/.rvm/gems/ruby-1.9.2-p180@thrift/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:14:in `load_files'
        from /home/psanford/.rvm/gems/ruby-1.9.2-p180@thrift/gems/rspec-1.3.2/lib/spec/runner/options.rb:134:in `run_examples'
        from /home/psanford/.rvm/gems/ruby-1.9.2-p180@thrift/gems/rspec-1.3.2/lib/spec/runner/command_line.rb:9:in `run'
        from /home/psanford/.rvm/gems/ruby-1.9.2-p180@thrift/gems/rspec-1.3.2/bin/spec:5:in `<main>'
rake aborted!

If I cd into the spec dir and run 'spec *spec.rb' everything works.

The problem is all the spec files require the spec_helper via:

require File.dirname(__FILE__) + '/spec_helper'

This will expand the dirname relative to where ruby was invoked. Changing this to:

require File.expand_path(File.dirname(__FILE__) + '/spec_helper')

will fix this issue.