[THRIFT-1407] Typo in Python socket server causes Thrift to fail when we enable a global socket timout

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8
• Fix Version/s: 0.8
• Component/s: Python - Library
• Labels: patch python socket timeout
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Adam Dalc
• Created: 26/Oct/11 11:40
• Updated: 26/Oct/11 12:50
• Resolved: 26/Oct/11 12:34

Description

There is a typo in thrift.transport.TSocket.TServerSocket: instead of "settimeout", we have "set_timeout". This causes the code to not work properly when we enable a global socket timeout in Python, using "socket.settimeout(30)". Because of the typo, the Python Thrift server will fail to change it's socket back to a non-timing out mode, and the listen call will fail after the timeout passes.