Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2422 Merge fbthrift
  3. THRIFT-1380

Thrift: Write-only PHP serialization protocol

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Invalid
    • None
    • None
    • C++ - Library
    • None

    Description

      From c9cd369f4352472f62b1b1f23dd3bee122c97b14 Mon Sep 17 00:00:00 2001
      From: David Reiss <dreiss@fb.com>
      Date: Mon, 10 May 2010 19:17:11 +0000
      Subject: [PATCH 8/9] Thrift: Write-only PHP serialization protocol

      Summary:

      • It's a bit sloppy, but not too bad.
      • It will happily serialize data that cannot be represented in PHP (like
        maps with lists as keys).
      • No support for sets.
      • The hardest part is getting the "keys" right for a list.

      davejwatson: also added to Makefile.am

      Test Plan:
      Used it to serialize some not-totally-trivial data and PHP was happy
      with it.

      Revert Plan:
      ok


      lib/cpp/Makefile.am | 2 +
      lib/cpp/src/protocol/TPhpSerializeProtocol.cpp | 212 ++++++++++++++++++++++++
      lib/cpp/src/protocol/TPhpSerializeProtocol.h | 114 +++++++++++++
      3 files changed, 328 insertions, 0 deletions
      create mode 100644 lib/cpp/src/protocol/TPhpSerializeProtocol.cpp
      create mode 100644 lib/cpp/src/protocol/TPhpSerializeProtocol.h

      Attachments

        Activity

          People

            jking3 James E. King III
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: