Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1378

Allow non-array (object) containers

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: PHP - Compiler
    • Labels:
      None

      Description

      From d1fed17d046a30d4e98ee60d478d392af544fa0e Mon Sep 17 00:00:00 2001
      From: Thomas Kho <tkho@fb.com>
      Date: Mon, 26 Apr 2010 21:13:29 +0000
      Subject: [PATCH 6/9] Thrift/PHP: Allow non-array (object) containers

      Summary:
      When writing out a Thrift struct, allow container fields to be
      objects that implement Iterator and Countable, in addition to plain
      arrays.

      Test Plan:
      Built a facebook project and tested serializing objects

      Revert Plan:
      OK


      compiler/cpp/src/generate/t_php_generator.cc | 22 ++++++++++++++--------
      1 files changed, 14 insertions, 8 deletions

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              davejwatson@fb Dave Watson
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: