Thrift
  1. Thrift
  2. THRIFT-1353

Switch to performance branch, get rid of BinaryParser

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.9.1
    • Component/s: Node.js - Library
    • Labels:

      Description

      I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance

      I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?

        Issue Links

          Activity

          Henrique Mendonça made changes -
          Link This issue contains THRIFT-1352 [ THRIFT-1352 ]
          Wade Simmons made changes -
          Link This issue is depended upon by THRIFT-1351 [ THRIFT-1351 ]
          Jake Farrell made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Jake Farrell made changes -
          Fix Version/s 0.9.1 [ 12324608 ]
          Fix Version/s 1.0 [ 12318851 ]
          Jake Farrell made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Henrique Mendonça made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Henrique Mendonça made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Roger Meier [ roger.meier ] Henrique Mendonca [ henrique ]
          Resolution Fixed [ 1 ]
          Henrique Mendonça made changes -
          Link This issue is related to THRIFT-1648 [ THRIFT-1648 ]
          Henrique Mendonça made changes -
          Attachment THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch [ 12519281 ]
          Henrique Mendonça made changes -
          Jake Farrell made changes -
          Fix Version/s 1.0 [ 12318851 ]
          Fix Version/s 0.9 [ 12316294 ]
          Jake Farrell made changes -
          Assignee Jake Farrell [ jfarrell ] Roger Meier [ roger.meier ]
          Jake Farrell made changes -
          Assignee Jake Farrell [ jfarrell ]
          Henrique Mendonça made changes -
          Attachment THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch [ 12519281 ]
          Wade Simmons made changes -
          Link This issue is duplicated by THRIFT-1497 [ THRIFT-1497 ]
          Jake Farrell made changes -
          Fix Version/s 0.9 [ 12316294 ]
          Fix Version/s 0.8 [ 12316293 ]
          Jake Farrell made changes -
          Fix Version/s 0.8 [ 12316293 ]
          Jake Farrell made changes -
          Field Original Value New Value
          Fix Version/s 0.8 [ 12316293 ]
          Hans Duedal created issue -

            People

            • Assignee:
              Henrique Mendonça
              Reporter:
              Hans Duedal
            • Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development