[THRIFT-1341] TProtocol.h endian detection wrong with boost

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.7, 0.8
• Fix Version/s: 0.8
• Component/s: C++ - Library
• Labels: patch

Environment

Windows

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: alexandre parenteau
• Created: 12/Sep/11 20:09
• Updated: 01/Nov/11 00:57
• Resolved: 12/Sep/11 22:26

Description

When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), TProtocol.h uses boost to detect the endianess, but does it wrong: boost's endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike endian.h)

Attached is a patch against trunk which fixes the code that uses boost. Tested on Windows, boost 1.44.0.