Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1341

TProtocol.h endian detection wrong with boost

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.7, 0.8
    • 0.8
    • C++ - Library
    • Windows

    • Patch Available

    Description

      When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), TProtocol.h uses boost to detect the endianess, but does it wrong: boost's endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike endian.h)

      Attached is a patch against trunk which fixes the code that uses boost. Tested on Windows, boost 1.44.0.

      Attachments

        1. THRIFT-1341.patch
          0.7 kB
          alexandre parenteau

        Activity

          People

            Unassigned Unassigned
            aubonbeurre alexandre parenteau
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified