Thrift
  1. Thrift
  2. THRIFT-1327

Fix Spec Suite under Ruby-1.8.7 (works for MRI Ruby-1.9.2)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.8
    • Fix Version/s: 0.9
    • Component/s: Ruby - Library
    • Labels:
      None
    • Environment:

      Ruby-1.8.7 (MRI/JRuby/Rubinius)

      Description

      The Spec suite is currently exhibiting issues, when run under Ruby 1.8.7. Ruby 1.8.7 interpreters MRI, JRuby, and Rubinius should all be tested and verified as working.

      In addition, it would make sense to use something like RVM, on the CI server, so we can easily test compatibility across different Ruby versions and interpreters.

      This does not affect Ruby-1.9.2 MRI, and has not been tested under JRuby's 1.9 mode. CI should run JRuby twice, under both the 1.8 and 1.9 compatibility-modes.

        Activity

        Hide
        Jake Farrell added a comment -

        Since the CI is not a dedicated set of machines to the Thrift project we can not switch the global version of ruby which other projects may be running tests against. Closing as won't fix for now due to this

        Show
        Jake Farrell added a comment - Since the CI is not a dedicated set of machines to the Thrift project we can not switch the global version of ruby which other projects may be running tests against. Closing as won't fix for now due to this
        Hide
        Ilya Maykov added a comment -

        Rvm is kind of a monster and brings a bunch of problems of its own. We've started using rbenv (https://github.com/sstephenson/rbenv) with ruby-build (https://github.com/sstephenson/ruby-build) at my work and it's working out much better for us.

        Show
        Ilya Maykov added a comment - Rvm is kind of a monster and brings a bunch of problems of its own. We've started using rbenv ( https://github.com/sstephenson/rbenv ) with ruby-build ( https://github.com/sstephenson/ruby-build ) at my work and it's working out much better for us.
        Hide
        Jake Farrell added a comment -

        We shouldn't install packages on the CI this way, if we choose to add rvm for testing then we need to put in a request to infra to have it put on all CI servers. Also other projects using ruby for testing could run into issues if we switched the default ruby version during our tests. I think we should look at adding this as an optional item within the ruby makefile which can be run locally for users with existing rvm setups.

        Show
        Jake Farrell added a comment - We shouldn't install packages on the CI this way, if we choose to add rvm for testing then we need to put in a request to infra to have it put on all CI servers. Also other projects using ruby for testing could run into issues if we switched the default ruby version during our tests. I think we should look at adding this as an optional item within the ruby makefile which can be run locally for users with existing rvm setups.
        Hide
        Roger Meier added a comment -

        I do not know rvm.. i did a

         bash < <(curl -s https://raw.github.com/wayneeseguin/rvm/master/binscripts/rvm-installer)
        

        see https://builds.apache.org/view/S-Z/view/Thrift/job/Thrift-env-test/44/console

        I do not know yet, but it might be possible to install rvm before we build.

        just add some patches and i add them to ci job for verification.

        Show
        Roger Meier added a comment - I do not know rvm.. i did a bash < <(curl -s https://raw.github.com/wayneeseguin/rvm/master/binscripts/rvm-installer) see https://builds.apache.org/view/S-Z/view/Thrift/job/Thrift-env-test/44/console I do not know yet, but it might be possible to install rvm before we build. just add some patches and i add them to ci job for verification.
        Hide
        Jake Farrell added a comment -

        Roger, rvm currently is not available on the ci servers, what are your thoughts on pushing for this and testing across multiple versions of ruby vs just supporting the latest version available on the ci server? I think this is a nice to have but more than we can currently support since the ci servers are a stock build

        Show
        Jake Farrell added a comment - Roger, rvm currently is not available on the ci servers, what are your thoughts on pushing for this and testing across multiple versions of ruby vs just supporting the latest version available on the ci server? I think this is a nice to have but more than we can currently support since the ci servers are a stock build

          People

          • Assignee:
            Jake Farrell
            Reporter:
            Scott Gonyea
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development