Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1293

thrift: improve handling of exceptions thrown by

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.8
    • C++ - Library
    • None

    Description

      From 68ed500b994bbe3beeb2eb66e052c6af7ef3a72c Mon Sep 17 00:00:00 2001
      From: Adam Simpkins <simpkins@fb.com>
      Date: Tue, 6 Apr 2010 20:59:29 +0000
      Subject: [PATCH 19/33] thrift: improve handling of exceptions thrown by
      process()

      Summary:
      Update the server code to print the exeption message for any
      std::exception that is thrown by process(), and not just TExceptions.
      Also print the exception type in the message.

      Test Plan:
      Used it to debug some broken code that was throwing std::length_error.
      (That turned out to just be a race condition in some of my test code.)

      Revert Plan:
      OK


      lib/cpp/src/server/TNonblockingServer.cpp | 25 ++++++++++++++-----------
      lib/cpp/src/server/TSimpleServer.cpp | 8 ++++----
      lib/cpp/src/server/TThreadPoolServer.cpp | 11 ++++-------
      lib/cpp/src/server/TThreadedServer.cpp | 8 ++++----
      4 files changed, 26 insertions, 26 deletions

      Attachments

        Activity

          People

            davejwatson@fb Dave Watson
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: