Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1289

thrift: implement TNonblockingServer::stop()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.8
    • C++ - Library
    • None

    Description

      From e92b398e5bef8eb652969308862f39d9a04a589f Mon Sep 17 00:00:00 2001
      From: Adam Simpkins <simpkins@fb.com>
      Date: Tue, 6 Apr 2010 20:43:20 +0000
      Subject: [PATCH 16/33] thrift: implement TNonblockingServer::stop()

      Summary:
      Previously calling stop() on a TNonblockingServer did nothing. Now it
      correctly causes serve() to exit.

      Test Plan:
      Tested with the test code in [some fb unittests]. This causes the
      TNonblockingServer tests to no longer hang trying to stop the server.

      Revert Plan:
      OK

      Conflicts:

      lib/cpp/src/server/TNonblockingServer.cpp

      lib/cpp/src/server/TNonblockingServer.cpp | 42 ++++++++++++++++++++++++++++-
      lib/cpp/src/server/TNonblockingServer.h | 5 +++
      2 files changed, 46 insertions, 1 deletions

      Attachments

        Activity

          People

            davejwatson@fb Dave Watson
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: