Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1287

thrift: start refactoring some of the C++ processor

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.8
    • C++ - Library
    • None

    Description

      From 527b9dc312e3dc45a18e15b50c0daf7dab52bfb5 Mon Sep 17 00:00:00 2001
      From: Adam Simpkins <simpkins@fb.com>
      Date: Sat, 3 Apr 2010 02:49:48 +0000
      Subject: [PATCH 14/33] thrift: start refactoring some of the C++ processor
      code generation

      Summary:
      This adds a ProcessorGenerator class to store all of the local variables
      used by generate_service_processor(). This way we can break up that
      giant function into some smaller pieces.

      The code is still pretty ugly, but it's a start.

      Test Plan:
      Built [two fb projects], and some additional thrift test files, and made
      sure the generated files were identical both before and after these
      changes.

      Revert Plan:
      OK

      Conflicts:

      compiler/cpp/src/generate/t_cpp_generator.cc

      compiler/cpp/src/generate/t_cpp_generator.cc | 346 ++++++++++++++++----------
      1 files changed, 216 insertions, 130 deletions

      Attachments

        Activity

          People

            davejwatson@fb Dave Watson
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: