Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1286

Modernize the Thrift Ruby Library Dev Environment

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.7, 0.8
    • 0.8
    • Ruby - Library
    • None
    • Patch Available

    Description

      This fixes the ruby libraries environment. This introduces Bundler for managing the development environment, as well as in handling the Gem release process. Echoe is no longer present.

      The end result is that the development environment is easier to setup and easier to reproduce. Thus, easier to contribute to.

      This structures the spec folder to better follow conventions RSpec.

      The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 2. This brings everything into the land of RSpec 2. Some additional cleanup could definitely be done, but this gets us out of the deprecation warnings and other weird behavior-ings.

      To run this in CI, however that is done, you'll effectively want the shell script (or whatever) to look like this:

      which bundle || gem install bundler
      bundle install
      bundle exec rake spec

      Patch should be pulled from:

      https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b

      or up to the commit:

      https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b

      Attachments

        1. thrift-1286.patch
          47 kB
          Jake Farrell
        2. thrift-1286.patch
          4 kB
          Jake Farrell
        3. thrift-1286.patch
          259 kB
          Scott Gonyea
        4. thrift-1286.patch
          230 kB
          Scott Gonyea
        5. thrift-1286.patch
          2 kB
          Jake Farrell

        Activity

          People

            jfarrell Jake Farrell
            sgonyea Scott Gonyea
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: