[THRIFT-1280] Thrift: Improve Monitor exception-free interfaces

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.8
• Component/s: C++ - Library
• Assignee: Dave Watson
• Reporter: Dave Watson
• Created: 22/Aug/11 16:27
• Updated: 24/Aug/11 00:42
• Resolved: 24/Aug/11 00:36

Description

From 768369c358664e2344366a82b80530a6308f3c32 Mon Sep 17 00:00:00 2001
From: Mark Rabkin <[e-mail]>
Date: Tue, 16 Mar 2010 00:52:07 +0000
Subject: [PATCH 09/33] Thrift: Improve Monitor exception-free interfaces

Summary:

Cleans up the code for the various variants of Monitor::wait() to reuse
code cleanly and to present exception-free variants for all types of waiting
(waiting forever, absolute timestamp, relative timeout).

The behavior of existing variants should be unchanged

Test Plan: run more thrift tests if you guys point me to them

• begin PUBLIC platform impact section -
  Bugzilla: #
• end platform impact -

Conflicts:

lib/cpp/src/concurrency/Monitor.cpp
lib/cpp/src/concurrency/Monitor.h
—
lib/cpp/src/concurrency/Monitor.cpp | 76 ++++++++++++++++++++++++++---------
lib/cpp/src/concurrency/Monitor.h | 34 +++++++++++++++-
2 files changed, 89 insertions, 21 deletions