Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1271

thrift: fix missing namespace in generated local

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.8
    • C++ - Library
    • None

    Description

      From a0ef2f341fcb613728c6be888082dfe98cde0ad8 Mon Sep 17 00:00:00 2001
      From: Adam Simpkins <simpkins@fb.com>
      Date: Thu, 14 Jan 2010 23:02:40 +0000
      Subject: [PATCH 03/33] thrift: fix missing namespace in generated local
      reflection

      Summary:
      The TypeSpec definitions for lists, sets, and maps did not prefix the contained
      type names with the correct namespace. This resulted in a compile failure when
      defining a list of types from another namespace.

      Test Plan:
      Tested building [internal fb thing]'s [internal fb thing] changes. The generated C++ code compiles now.


      compiler/cpp/src/generate/t_cpp_generator.cc | 8 ++++----
      1 files changed, 4 insertions, 4 deletions

      Attachments

        Activity

          People

            davejwatson@fb Dave Watson
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: