[THRIFT-1244] using 'using' to disambiguate between functions in different bases does not conform to C++ standard and will not compile on certain compilers

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.6
• Fix Version/s: 0.7
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: Anatoly Fayngelerin
• Reporter: Anatoly Fayngelerin
• Created: 27/Jul/11 14:15
• Updated: 10/Aug/11 18:27
• Resolved: 28/Jul/11 18:05

Description

Currently in transport/TBufferTransports.h three classes have code of the form

using TBufferBase::readAll;

This code is attempting to disambiguate between the readAll function provided by TBufferBase and TVirtualTransport < T, TBufferBase >. This compile and works under GCC. However, this does not conform to the C++ standard. Other compilers(such as Comeau) will report compilation errors because of this code. Here is a related bug filed with gcc: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32039

I am attaching a patch that explicitly declares readAll and implements it by calling TBufferBase::readAll.