[THRIFT-1229] Python fastbinary.c can not handle unicode as generated python code

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.10.0
• Component/s: Python - Compiler, Python - Library

Environment

mac osx 10.6

• Assignee: Nobuaki Sukegawa
• Reporter: Favo
• Created: 01/Jul/11 09:06
• Updated: 19/Feb/16 02:17
• Resolved: 05/Feb/16 12:29

Description

#THRIFT-395 (r959516) fixed python unicode support by adding a parameter to thrift command line for py-generator. However this will not affect fastbinary.c. A normal generated Read/Write function looks like below, notice that the function returned before reach unicode handling logic.

TType.py

  def write(self, oprot):
    if oprot.__class__ == TBinaryProtocol.TBinaryProtocolAccelerated and self.thrift_spec is not None and fastbinary is not None:
      oprot.trans.write(fastbinary.encode_binary(self, (self.__class__, self.thrift_spec)))
      return
    if self.ip is not None:
      oprot.writeFieldBegin('ip', TType.STRING, 6)
      oprot.writeString(self.ip.encode('utf-8'))
      oprot.writeFieldEnd()

Any suggestion for this?

Issue Links

• is duplicated by: THRIFT-3519 fastbinary does not work with -gen py:utf8strings