[THRIFT-1222] Unhandled exception for TEvhttpServer request

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6.1, 0.7
• Fix Version/s: 0.7
• Component/s: C++ - Library
• Labels: patch

Environment

Any

• Patch Info: Patch Available
• Assignee: alexandre parenteau
• Reporter: alexandre parenteau
• Created: 28/Jun/11 06:58
• Updated: 10/Aug/11 18:27
• Resolved: 17/Jul/11 07:17

Description

When an error occur during a HTTP request, exceptions are not captured before entering back libevent. For example a simple 'curl http://localhost:8080' will trigger a 'not enough data' exception, however no code will actually set the HTTP status (triggering a unhandled exception, and a crash).

Here is a proposed change:

void TEvhttpServer::request(struct evhttp_request* req, void* self) {
try

{ static_cast<TEvhttpServer*>(self)->process(req); }

catch(std::exception& e)

{ evhttp_send_reply(req, HTTP_INTERNAL, e.what(), 0); }

}