[THRIFT-1211] When using THttpClient, non 200 responses leave the connection open

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6.1
• Fix Version/s: 0.7
• Component/s: Java - Library

Environment

All

• Patch Info: Patch Available
• Assignee: Mathias Herberts
• Reporter: Mathias Herberts
• Created: 16/Jun/11 22:53
• Updated: 22/Jun/11 17:25
• Resolved: 20/Jun/11 21:42

Description

The call to HttpClient.execute is done in a try/catch/finally which includes closing of entity's input stream in the finally clause (thus freeing resources).

The problem is that when the response code is not 200 (OK), an exception is thrown BEFORE the inputstream is retrieved from the response's entity, when executing the finally clause, the resources are not freed as the inputstream is null.