[THRIFT-1200] JS compiler generates code that clobbers existing namespaces

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6.1
• Fix Version/s: 0.7
• Component/s: JavaScript - Compiler

Environment

all

• Patch Info: Patch Available
• Assignee: Ilya Maykov
• Reporter: Ilya Maykov
• Created: 08/Jun/11 20:43
• Updated: 09/Jun/11 22:33
• Resolved: 08/Jun/11 23:51

Description

The JavaScript compiler currently generates code that will clobber an already-existing namespace. It should check if the namespace exists before initializing it to {}. Example code pre-patch, assuming the .thrift file has the declaration namespace js CompanyName.ModuleName:

var CompanyName = {};
CompanyName.ModuleName = {}

Becomes this after patch:

if (typeof CompanyName === 'undefined') CompanyName = {};
if (typeof CompanyName.ModuleName === 'undefined') CompanyName.ModuleName = {};