[THRIFT-1184] event_base memory freeing by class TNonblockingServer

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: C++ - Library
• Labels: libevent
• Patch Info: Patch Available
• Assignee: Pavlin Radoslavov
• Reporter: Pavlin Radoslavov
• Created: 29/May/11 21:27
• Updated: 08/Dec/11 10:23
• Resolved: 02/Aug/11 23:41

Description

The TNonblockingServer::eventBase_ pointer is assigned
by method TNonblockingServer::registerEvents()
so the libevent events are added to the proper libevent event base.

Currently the TNonblockingServer destructor unconditionally
calls event_base_free(eventBase_) to free the eventBase_ memory.

In certain cases the libevent event base might be allocated and
deallocated by a third-party software that uses Thrift, so it is
not appropriate for the TNonblockingServer destructor to unconditionally
call event_base_free(eventBase_).

Please see attached patch for a possible solution:
add an optional bool argument to method TNonblockingServer::registerEvents():
the value of that flag controls whether the TNonblockingServer destructor
should call event_base_free(eventBase_).

The argument is optional, and defaults to true (i.e, event_base_free(eventBase_)
is called) for API (and behavior) backward compatibility.

Issue Links

• is related to: THRIFT-1442 TNonblockingServer: Refactor to allow multiple IO Threads