Thrift
  1. Thrift
  2. THRIFT-1128

MAC OS X: thrift.h incompatibility with Thrift.h

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.9
    • Component/s: None
    • Environment:

      Mac OS X 10.6.7

      Description

      The default filesystem on Mac OS X is case-insensitive

      If thrift is compiled with c_glib support, upon install, the "thrift.h" installed by c_glib trumps the classical "Thrift.h" C++ header.

      C++ apps afterwards fail to compile (for obvious reasons).

      Had to re-compile+install libthrift without c_glib support to get back the original contents of Thrift.h needed for C++ support

      1. thrift-1128.patch
        0.5 kB
        Jake Farrell
      2. thrift-1128.patch
        0.5 kB
        Jake Farrell

        Activity

        Hide
        Jake Farrell added a comment -

        Thoughts on moving the client from $

        {prefix}/include/thrift to ${prefix}

        /include/thrift/client/g_libc to avoid collisions on thrift.h ?

        Show
        Jake Farrell added a comment - Thoughts on moving the client from $ {prefix}/include/thrift to ${prefix} /include/thrift/client/g_libc to avoid collisions on thrift.h ?
        Hide
        Jake Farrell added a comment -

        My first patch had a typo, updated header install location to $

        {prefix}

        /include/thrift/client/c_glib

        Show
        Jake Farrell added a comment - My first patch had a typo, updated header install location to $ {prefix} /include/thrift/client/c_glib
        Hide
        Jake Farrell added a comment -

        Moved c_glib headers to $(includedir)/thrift/c_glib to avoid collisions with cpp headers

        Show
        Jake Farrell added a comment - Moved c_glib headers to $(includedir)/thrift/c_glib to avoid collisions with cpp headers
        Hide
        Hudson added a comment -

        Integrated in Thrift #421 (See https://builds.apache.org/job/Thrift/421/)
        THRIFT-1128:MAC OS X thrift.h incompatibility with Thrift.h
        Client: cpp, c_glib
        Patch: Jake Farrell

        Moving c_glib headers into $(includedir)/thrift/c_glib to not collide with cpp headers. (Revision 1296038)

        Result = SUCCESS
        jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1296038
        Files :

        • /thrift/trunk/lib/c_glib/Makefile.am
        Show
        Hudson added a comment - Integrated in Thrift #421 (See https://builds.apache.org/job/Thrift/421/ ) THRIFT-1128 :MAC OS X thrift.h incompatibility with Thrift.h Client: cpp, c_glib Patch: Jake Farrell Moving c_glib headers into $(includedir)/thrift/c_glib to not collide with cpp headers. (Revision 1296038) Result = SUCCESS jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1296038 Files : /thrift/trunk/lib/c_glib/Makefile.am

          People

          • Assignee:
            Jake Farrell
            Reporter:
            Mina Naguib
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development