Thrift
  1. Thrift
  2. THRIFT-1111

The HTML generator does not distinguish between string and binary types

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.7
    • Component/s: Compiler (General)
    • Labels:
      None

      Description

      Given the following service method defined in thrift IDL,

      list<string> my_method(
      1: string arg1,
      3: map<binary, map<binary, binary>> arg2,
      )

      I would expect the html doc generated to reflect that arg is a string argument while elements in arg2 are of "binary" type.
      Currently HTML generator prints "string" type for both cases, misleading the API users.

      1. THRIFT-1111.patch
        0.6 kB
        Adrian Muraru

        Activity

        Adrian Muraru created issue -
        Hide
        Adrian Muraru added a comment -

        Patch to print binary types as such

        Show
        Adrian Muraru added a comment - Patch to print binary types as such
        Adrian Muraru made changes -
        Field Original Value New Value
        Attachment THRIFT-1111.patch [ 12474499 ]
        Hide
        Bryan Duxbury added a comment -

        I just committed this patch. Thanks Adrian!

        Show
        Bryan Duxbury added a comment - I just committed this patch. Thanks Adrian!
        Bryan Duxbury made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Adrian Muraru [ amuraru ]
        Fix Version/s 0.7 [ 12315360 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Thrift #105 (See https://hudson.apache.org/hudson/job/Thrift/105/)
        THRIFT-1111. html: The HTML generator does not distinguish between string and binary types

        Patch: Adrian Muraru

        Show
        Hudson added a comment - Integrated in Thrift #105 (See https://hudson.apache.org/hudson/job/Thrift/105/ ) THRIFT-1111 . html: The HTML generator does not distinguish between string and binary types Patch: Adrian Muraru
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        1d 4h 11m 1 Bryan Duxbury 25/Mar/11 17:28

          People

          • Assignee:
            Adrian Muraru
            Reporter:
            Adrian Muraru
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development