[THRIFT-1105] OCaml generator does not prefix methods of included structs with their type

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.7
• Component/s: OCaml - Compiler

Environment

Mac OSX 10.6

• Patch Info: Patch Available
• Assignee: Joel Reymont
• Reporter: Joel Reymont
• Created: 22/Mar/11 07:46
• Updated: 23/Mar/11 18:15
• Resolved: 23/Mar/11 17:58

Description

— Doc.thrift

struct Document {
1: string user_name
2: string document_name
}

typedef Document page_id

— Ranking.thrift

include "Doc.thrift"

struct Request {
1: Doc.page_id page
}

—

thrift -gen ocaml Doc.thrift
thrift -gen ocaml Ranking.thrift

—

You will see

#set_page (read_document iprot)

generated in read_request, instead of the proper

#set_page (Doc_types.read_document iprot)

Generated code fails to compile as a result.