[THRIFT-1057] casts in TBinaryProtocol.tcc causing "dereferencing type-punned pointer will break strict-aliasing rules" warnings from gcc

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.7
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: Christian Lavoie
• Reporter: Chris Morgan
• Created: 08/Feb/11 22:07
• Updated: 09/Mar/11 18:17
• Resolved: 08/Feb/11 23:06

Description

Code is doing things like:

uint8_t b[2];
uint16_t val;

val = *(int16_t*)b;

Due to aliasing there isn't a guarantee that b[] will be placed on a 16 bit boundary.

Fix is to use unions to ensure alignment. Patch attached.