[THRIFT-1050] Declaring an argument named "manager" to a service method produces code that fails compile due to name conflicts with protected ivars in TAsyncClient

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.5
• Fix Version/s: 0.7
• Component/s: Java - Compiler, Java - Library
• Assignee: Bryan Duxbury
• Reporter: Tony Kinnis
• Created: 28/Jan/11 01:46
• Updated: 15/Mar/11 17:25
• Resolved: 15/Mar/11 17:25

Description

The java code that is generated for a service method that has a argument named "manager" fails to compile. The TAsyncClient class declares a protected instance variable named "manager" and the generated code for the async call of that method declares a parameter called manager and also tries to use the instance variable called to dispatch the async call, however it can't since the method argument is shadowing the instance variable.

Here is an example of the invalid code that is generated.

public void savePerson(Person manager, AsyncMethodCallback<savePerson_call> resultHandler) throws TException {
  checkReady();
  savePerson_call method_call = new savePerson_call(manager, resultHandler, this, protocolFactory, transport);
  manager.call(method_call); // XXXX This is where the compile error occurs
}

I think having a argument named "manager" could be fairly common.

There are two potential fixes to this problem.
1. rename TAsyncClient's instance variable to something more obscure and less likely to collide, like asyncClientManager
2. make the variable private and access it via a method

I think changes would need to be made in TAsyncClient.java as well as the code generator.

There are two other member variables with protected access that could also create similar conflicts.
protocolFactory
transport