[THRIFT-1047] rb_thrift_memory_buffer_write treats arg as string without check, segfaults if you pass non-string

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5
• Fix Version/s: 0.9.2
• Component/s: Ruby - Library
• Assignee: Unassigned
• Reporter: Jake Donham
• Created: 25/Jan/11 21:10
• Updated: 15/Jan/14 02:59
• Resolved: 12/Jan/14 22:30

Description

I think there should be a call to Check_Type(str, T_STRING) in there

VALUE rb_thrift_memory_buffer_write(VALUE self, VALUE str) {
VALUE buf = GET_BUF(self);
rb_str_buf_cat(buf, RSTRING_PTR(str), RSTRING_LEN(str));
return Qnil;
}

Issue Links

• is part of: THRIFT-2182 segfault in regression tests (GC bug in rb_thrift_memory_buffer_write)